feat: dropping our position system for ordering commands in --help
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
approved these changes
Dec 8, 2022
| return cmds | ||
| .sort((a, b) => (a.position > b.position ? 1 : -1)) | ||
| .sort((a, b) => (a.name > b.name ? 1 : -1)) |
There was a problem hiding this comment.
a lot of our behind-the-scenes logic here is such a mess lol. the field is called command in the command file but name here. got it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We've long had this
positionsystem within our individual commands for positioning where they show up on--helpscreens with the goal of prioritizing the more important commands over those that aren't, however we've always just named our important commands to not have an:actionin their name so they've always been at the top of the list anyways.The only
--helpchange that's happening with this removal is movingversions:deletefrom being at the end of its group to now being afterversions:create(bfd):🧬 QA & Testing
Main
--helpCommand
--helpProvide as much information as you can on how to test what you've done.