Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: caching deps in ci #696

Merged
merged 2 commits into from
Dec 2, 2022
Merged

ci: caching deps in ci #696

merged 2 commits into from
Dec 2, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Dec 1, 2022

No description provided.

@erunion erunion marked this pull request as ready for review December 1, 2022 18:20
@erunion erunion requested a review from kanadgupta December 1, 2022 18:22
@kanadgupta
Copy link
Member

It looks like all the Node versions are using the same cache when looking at these test results:

https://github.com/readmeio/rdme/actions/runs/3595384865/jobs/6054805504#step:11:5
https://github.com/readmeio/rdme/actions/runs/3595384865/jobs/6054805622#step:11:5

Is that going to be an issue?

@erunion
Copy link
Member Author

erunion commented Dec 1, 2022

Shouldn't be because it's all coming from the same lockfile.

@kanadgupta kanadgupta merged commit baff9c0 into main Dec 2, 2022
@kanadgupta kanadgupta deleted the ci/dep-caching branch December 2, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants