Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(createGHA): remove non-github remote check #665

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Nov 7, 2022

🧰 Changes

Tightening our requirements for executing the GitHub Actions prompt: now, a user must have a GitHub remote for their repo in order for the ask to be made. We've had a few issues related to this prompt running when it shouldn't, so this should hopefully reduce the likelihood of a false positive.

🧬 QA & Testing

Do tests pass?

Tightening our requirements for executing the GitHub Actions prompt: now, a user *must* have a GitHub remote for their repo in order for the ask to be made.
@kanadgupta kanadgupta added bug Something isn't working GHA / CI Issues specific to GitHub Actions or other CI environments labels Nov 8, 2022
@kanadgupta kanadgupta marked this pull request as ready for review November 11, 2022 17:21
@kanadgupta kanadgupta requested a review from erunion November 11, 2022 17:21
@kanadgupta kanadgupta merged commit 480cdad into main Nov 11, 2022
@kanadgupta kanadgupta deleted the loosen-GHA-checks branch November 11, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GHA / CI Issues specific to GitHub Actions or other CI environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants