Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs:prune): --confirm flag to bypass prompt #648

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

shaiarmis
Copy link
Contributor

🧰 Changes

Add --noPrompt flag to the docs:prune command

🧬 QA & Testing

  1. Manually add a document to your project in the UI.
  2. Run the docs:prune command as is, see that it asks for confirmation before deleting the document.
  3. Run again but with --noPrompt and see that the document is deleted from the project.

@kanadgupta kanadgupta changed the title Add support for docs:prune --noPrompt for CI environments feat(docs:prune): --confirm flag to bypass prompt Oct 31, 2022
@kanadgupta kanadgupta added enhancement New feature or request command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands labels Oct 31, 2022
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the flag, cleaned up the docs, and did a small refactor to simplify the code a bit. Thanks @shaiarmis!

@kanadgupta kanadgupta merged commit 34aa184 into readmeio:main Oct 31, 2022
@kanadgupta kanadgupta added this to the v8 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants