refactor(docs): move --cleanup option into docs:prune command
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
enhancement
erunion
reviewed
Oct 26, 2022
| @@ -30,7 +30,7 @@ export default class EditDocsCommand extends Command { | |||
| this.usage = 'docs:edit <slug> [options]'; | |||
There was a problem hiding this comment.
Honestly not opposed to deprecating this command now and removing it in v9.
god i hate this test lol
kanadgupta
force-pushed
the
kanad/rm-5598-migrate-docs---cleanup-option-into-a
branch
from
f214f0d to
7f60562
Compare
kanadgupta
changed the base branch from
kanad/rm-5580-consolidate-docs-and-docssingle
to
main
|
@shaiarmis FYI! |
kanadgupta
changed the title
--cleanup option into docs:prune command
erunion
approved these changes
Oct 27, 2022
kanadgupta
deleted the
kanad/rm-5598-migrate-docs---cleanup-option-into-a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Separates the
--cleanupoption on thedocscommand into a separate command calleddocs:prune. Thedocscommand logic was getting confusing and it feels like an entirely separate use-case that is worthy of a separate command. This entire command is wrapped in a prompt now so the user must say "yes" before continuing with the pruning.🧬 QA & Testing
Do the changes look good? And do tests pass?