-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi): Update oas file based on title #586
feat(openapi): Update oas file based on title #586
Conversation
I don't want to speak for @kanadgupta here but I'm leaning towards not pulling this in. This kind of upload flow is something we've been tossing around over the past month or two and I'd rather we do that 1, and make that the default experience than adding another new flag we need to maintain within the ever growing complexity of the Footnotes
|
@erunion @kanadgupta up to you both, do you have any sort of timeline for the enhancements to be delivered? We are encountering friction with developers as well as setting up our CI/CD, process for publishing. |
@garrett-wade No timelines as we're still formulating a plan for how it'll work, but we'd love to do it this year. |
Unfortunately I agree with @erunion—the complexity of the @garrett-wade could you elaborate on what your CI/CD use case is? As a short term solution, perhaps the changes in #577 could help with this? |
@kanadgupta Understood, the main issue is that there is nothing in the OAS file that can be specified to denote where it should go in Readme when uploaded. Rather the CI/CD job has to be configured to do so. This works nicely with docs because the user can specify a category id and slug in the grey matter, but there is no way do do this for an api spec rather than tracking the id of the doc after uploading and ensuring you save that for future use. |
Gonna close this out — we have some API changes in the works that should address this issue and will also benefit our non- |
🧰 Changes
Added the
--matchOnTitleAndVersion
parameter to theopenapi
command. This allows for an API Specification to be updated based on its title and version rather than a specific id in the readme database. This prevents a developer from having to know the id of the api spec they are updating improving the developer experience. Additional update include:🧬 QA & Testing
rdme openapi
rdme openapi --matchOnTitleAndVersion
without using the--id
parameter.