Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-readme-source header #58

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Add x-readme-source header #58

merged 1 commit into from
Aug 8, 2019

Conversation

mjcuva
Copy link
Member

@mjcuva mjcuva commented Aug 8, 2019

Add header to tell ReadMe that the synced file is coming from the cli

@erunion
Copy link
Member

erunion commented Aug 8, 2019

@mjcuva This LGTM. Do we need to wait for the cli header support in the app to get into prod before releasing this?

@erunion erunion requested review from gratcliff and erunion August 8, 2019 23:39
@domharrington
Copy link
Member

I don't think it'll have any adverse affects if this gets released before that gets merged. Right now it just defaults to cli.

@gratcliff
Copy link
Member

@domharrington is correct, it's hardcoded in dash/api/v1/api-specification right now at the base POST request.

@erunion
Copy link
Member

erunion commented Aug 8, 2019

Confirmed! Merging and tagging a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants