feat: minor refactor of how we debug and log out data in commands #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test broke because we slightly refactored the order in which we do version selection, so it had a nock that is no longer being hit.
Just as an additional sanity check, gonna use the weird version file again so we can ensure its version is not being adhered to unless the corresponding flag is passed.
this should have been a separate PR lol sorry
wtf VSCode...
Co-Authored-By: Jon Ursenbach <[email protected]>
erunion
commented
Aug 10, 2022
| @@ -30,15 +30,6 @@ | |||
| */ | |||
| "class-methods-use-this": ["error", { "exceptMethods": ["run"] }], | |||
|
|
|||
| "import/order": ["error", { | |||
There was a problem hiding this comment.
Moved into our core standards and tagged a major release of that pkg. readmeio/standards@edffdbe
Base automatically changed from
kanad/rm-4984-if-run-in-ci-environment-just-assume
to
main
August 10, 2022 05:39
kanadgupta
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Changes how we log out data in commands from calling
debug()to having those commands set up as static methods in our coreCommandclass.