refactor(openapi): DRY and logic reorg #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
refactor
erunion
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Combines the file-searching logic (i.e. auto-detection of
openapi.json,swagger.yml, etc.) from thevalidateandopenapicommands and puts it in ourprepareOashelper function. That function signature has changed a bit to handle that shared logic a bit better. I also refactored theopenapicommand to have a flow that is easier to follow.These changes are setting up the updates coming in RM-4898 and RM-4984.
🧬 QA & Testing
Might help to hide whitespace for this review! No changes were made to tests and no functional changes are happening so if all tests pass we should be good to go.