feat: changelog endpoints #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so we can reuse it for Changelog! 🚀 No functional changes were made, docs tests should still pass.
let's hope this is right lol
kanadgupta
commented
Jul 25, 2022
Comment on lines
+52
to
+62
| const readdirRecursive = folderToSearch => { | ||
| const filesInFolder = fs.readdirSync(folderToSearch, { withFileTypes: true }); | ||
| const files = filesInFolder | ||
| .filter(fileHandle => fileHandle.isFile()) | ||
| .map(fileHandle => path.join(folderToSearch, fileHandle.name)); | ||
| const folders = filesInFolder.filter(fileHandle => fileHandle.isDirectory()); | ||
| const subFiles = [].concat( | ||
| ...folders.map(fileHandle => readdirRecursive(path.join(folderToSearch, fileHandle.name))) | ||
| ); | ||
| return [...files, ...subFiles]; | ||
| }; |
There was a problem hiding this comment.
This is a small DRY opportunity but I'll pick this up once all the commands are finished.
kanadgupta
added
enhancement
erunion
reviewed
Jul 25, 2022
erunion
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds
changelogsandchangelogs:singleendpoints. Per the refactors in #540, this is a really lightweight wrapper around existing functionality.🧬 QA & Testing
This functionality is nearly identical to
docs. Feel free to play around or just look at the tests!