test(openapi/validate): cleanup 🧹 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also i realphabetized the imports
I tried running recreating this and the API responds with a 4xx, not a 5xx in this case.
it was bugging me how we had two tests that were uncategorized and clearly fit under the "upload" describe block (definitely my bad)
This error handling was unnecessary, as shown in the test I added. The validation section above it flags this, so there theoretically shouldn't be any errors bundling that wouldn't already be flagged in the validation section above.
…to openapi/test-housekeeping
…to openapi/test-housekeeping
8 tasks
Base automatically changed from
kanad/rm-4367-update-rdme-to-support-new-oas-upload
to
main
June 23, 2022 17:02
after noodling with this for a bit I couldn't figure it out 😞 so adding a TODO so someone can hopefully write a test for this.
erunion
approved these changes
Jun 23, 2022
| @@ -409,7 +415,7 @@ describe('rdme openapi', () => { | |||
| .post('/api/v1/api-specification', { registryUUID }) | |||
| .delayConnection(1000) | |||
| .basicAuth({ user: key }) | |||
| .reply(500, errorObject); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
As part of the work I did for #518, this PR fluffs out some missing test coverage and does some tiny refactors.
🧬 QA & Testing
Do tests pass? You can see the Node 14 test coverage before and after below (coverage improvements are in
lib/prepareOas.jsandcmds/opneapi.js).Before:
After: