Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for node 18 #495

Merged
merged 3 commits into from
Apr 20, 2022
+265 −300
Merged

feat: adding support for node 18 #495

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92fe8cc
feat: adding support for node 18
erunion Apr 20, 2022
1cb0fcf
test: fixing a broken test
erunion Apr 20, 2022
4b0a848
chore: update comment
kanadgupta Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x, 17.x]
node-version:
- 14
- 16
- 18

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion __tests__/lib/isSupportedNodeVersion.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ describe('#isSupportedNodeVersion()', () => {
it('should return true for a supported version of node', () => {
expect(isSupportedNodeVersion('14.5.1')).toBe(true);
expect(isSupportedNodeVersion('16.0.0')).toBe(true);
expect(isSupportedNodeVersion('18.0.0')).toBe(true);
});

it('should return false for an unsupported version of node', () => {
expect(isSupportedNodeVersion('10.0.0')).toBe(false);
expect(isSupportedNodeVersion('12.0.0')).toBe(false);
expect(isSupportedNodeVersion('18.0.0')).toBe(false);
});
});
Loading