Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a weirdly written promise #463

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix: a weirdly written promise #463

merged 1 commit into from
Mar 1, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Mar 1, 2022

🧰 Changes

Not sure why this promise was written this way but it's weird and I don't like it.

@erunion erunion added the refactor Issues about tackling technical debt label Mar 1, 2022
@erunion erunion requested a review from kanadgupta March 1, 2022 23:20
@erunion erunion added this to the v7 milestone Mar 1, 2022
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@erunion erunion merged commit 6827352 into main Mar 1, 2022
@erunion erunion deleted the fix/weird-promise branch March 1, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants