feat: sending a custom rdme user agent with all requests #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Feb 2, 2022
| "jest": true | ||
| }, | ||
| "rules": { | ||
| "jest/expect-expect": [ |
There was a problem hiding this comment.
All tests have explicit expect()s now so we don't need add these exclusions for nock.
erunion
changed the title
kanadgupta
approved these changes
Feb 2, 2022
Comment on lines
+189
to
+197
| await expect(docs.run({ folder: './__tests__/__fixtures__/new-docs', key, version })).resolves.toStrictEqual([ | ||
| { | ||
| slug: 'new-doc', | ||
| body: '\nBody\n', | ||
| category: '5ae122e10fdf4e39bb34db6f', | ||
| title: 'This is the document title', | ||
| lastUpdatedHash: 'a23046c1e9d8ab47f8875ae7c5e429cb95be1c48', | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
ugh we really had these tests in so many places lol 😭
| }); | ||
| await expect(docs.run({ folder: './__tests__/__fixtures__/slug-docs', key, version })).resolves.toStrictEqual([ | ||
| { | ||
| slug: 'marc-actually-wrote-a-test', |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable jest/no-conditional-expect */ | |||
There was a problem hiding this comment.
Could we disable it for each line or is it affecting the whole file?
There was a problem hiding this comment.
Every test in this one has a conditional expect unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Much to my surprise and chagrin we weren't already sending a custom
rdme/(major).(minor).(patch)user agent with all API requests. This fixes that!🧬 QA & Testing
I've slightly shuffled around the
cleanHeadersandhandleReslibraries we had insrc/libinto this newfetchwrapper insrc/lib/fetch. Anything that once loadednode-fetchnow loads this (which in turn loadsnode-fetch).I've also added some unit tests for this to make sure that user agents are getting sent, changed every command test that mocks calls to our API to mock that API call + the user agent, and also cleaned up a few command tests that didn't have any explicit assertions (they were just silently testing either the mocks would succeed or that the command wouldn't fail).