-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: commands into command classes #424
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
70557ac
fix: quirks with version commands not always handling errors properly
erunion 3d394d6
fix: use the right accessor for getting config data
erunion c6bf6da
refactor: commands into command classes
erunion e0521be
fix: typos
erunion eff1284
fix: we know the name of the login command
erunion aa36dd9
fix: reverting an unnecessary change
erunion ab02e04
fix: pr feedback
erunion 717ed68
Merge branch 'main' into refactor/command-classes
erunion 7b123cd
fix: bring back snapshot
erunion e2c10be
fix: pulling some snapshots that have color in them as they're causin…
erunion 2bd4199
test: tweaks
erunion 517d7ea
fix: removing a dupe color config
erunion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
node_modules | ||
coverage | ||
node_modules/ | ||
coverage/ | ||
swagger.json | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`rdme login should post to /login on the API 1`] = `"Successfully logged in as [email protected] to the subdomain project."`; | ||
|
||
exports[`rdme login should send 2fa token if provided 1`] = `"Successfully logged in as [email protected] to the subdomain project."`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,9 +34,7 @@ describe('rdme login', () => { | |
|
||
const mock = nock(config.get('host')).post('/api/v1/login', { email, password, project }).reply(200, { apiKey }); | ||
|
||
const output = await cmd.run({ email, password, project }); | ||
expect(output).toContain('[email protected]'); | ||
expect(output).toContain('subdomain'); | ||
await expect(cmd.run({ email, password, project })).resolves.toMatchSnapshot(); | ||
|
||
mock.done(); | ||
|
||
|
@@ -81,10 +79,7 @@ describe('rdme login', () => { | |
.post('/api/v1/login', { email, password, project, token }) | ||
.reply(200, { apiKey: '123' }); | ||
|
||
const output = await cmd.run({ email, password, project, token }); | ||
expect(output).toContain('[email protected]'); | ||
expect(output).toContain('subdomain'); | ||
|
||
await expect(cmd.run({ email, password, project, token })).resolves.toMatchSnapshot(); | ||
mock.done(); | ||
}); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
// The `chalk` and `colors` libraries have trouble with Jest sometimes in test snapshots so we're disabling | ||
// colorization here for all tests. | ||
process.env.FORCE_COLOR = 0; | ||
|
||
process.env.NODE_ENV = 'testing'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We technically shouldn’t need this since a successful test run will result in this file being deleted properly… but I suppose doesn’t hurt!