fix(openapi): return rejected Promise if spec uploads fail

[kanadgupta]

🧰 Changes

Turns out we had an edge case where we were returning a console.log() rather than a rejected Promise when we received errors from the API, resulting in an incorrectly successful exit code. This PR fixes that in 0f2372e so we properly return an exit code of 1. And as expected, some housekeeping:

• Refactors existing tests to check for the rejected Promise rather than a console output 8811c8c
• Adds additional test coverage to check for our other API error edge cases. We're now over 90% line coverage in the OpenAPI command file! 📈 8811c8c
• Slightly reformats our rejected Promise error outputs to be padded with newlines 9936de5
• Small fix to our general command handler so it properly uses our lengthier error message for invalid commands. 3b75d29 See below for a before and after:

Resolves #407.

🧬 QA & Testing

If the tests pass, we should be good! But as an extra check, you can check out this branch and run the following commands to confirm that we see a non-zero exit code:

$ bin/rdme openapi --id="asdf" --key="asdf" ./__tests__/__fixtures__/ref-oas/petstore.json

We couldn't find your API key.

If you need help, email [email protected] and include the following link to your API log: 'https://docs.readme.com/logs/xxx-xxx'.

$ echo $?
1

[erunion]

can't believe we weren't throwing an exit(1) for failed uploads 😞