Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(versions): stringify JSON for --raw option #404

Merged
merged 1 commit into from
Dec 13, 2021
Merged

feat(versions): stringify JSON for --raw option #404

merged 1 commit into from
Dec 13, 2021

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Dec 13, 2021 •
edited
Loading

🧰 Changes

Updates the --raw option so it outputs a JSON object rather than a JS object. Resolves #369.

🧬 QA & Testing

See tests! You can also check this branch out locally and run commands like:

bin/rdme versions --raw | jq

and do filtering with something like:

bin/rdme versions --raw | jq '.[] | select(.is_stable == true)'

@kanadgupta kanadgupta requested a review from erunion December 13, 2021 16:50
@erunion erunion added the enhancement New feature or request label Dec 13, 2021
@erunion erunion merged commit ce651e9 into main Dec 13, 2021
@erunion erunion deleted the fix/raw-version-json branch December 13, 2021 16:52
@kanadgupta kanadgupta mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rdme versions --raw doesn't output the raw JSON response
2 participants
@kanadgupta @erunion