Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version selection to all relevant commands #344

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

rahulhegdee
Copy link
Contributor

🧰 Changes

We had the option to select an existing version or create a new version with the openapi command if no version argument was provided, this PR adds that to all the commands that require the version argument.

  • Adds version selection to the relevant docs and version commands
  • Allows for specifying whether the user should receive the option to create a new version or just gives them a list of their current versions to choose from.

🧬 QA & Testing

  • Make sure tests pass.
  • Make sure you can still input a version as a command line argument

@erunion erunion added the enhancement New feature or request label Jul 29, 2021
src/lib/versionSelect.js Outdated Show resolved Hide resolved
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature and the code overall looks great, excited for this! Just one small piece of feedback on our usage of request-promise-native 👀

src/lib/versionSelect.js Show resolved Hide resolved
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works great!

__tests__/cmds/docs.test.js Outdated Show resolved Hide resolved
@rahulhegdee rahulhegdee merged commit d797d09 into main Aug 2, 2021
@rahulhegdee rahulhegdee deleted the allow-version-selection-for-all-relevant-rm-1469 branch August 2, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants