Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change docs command to always update all valid docs #338

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

rahulhegdee
Copy link
Contributor

@rahulhegdee rahulhegdee commented Jul 2, 2021

🧰 Changes

  • Fixes docs command issue where only some of the docs in a folder will update when an invalid doc is in the folder.
  • Fixes issue where invalid docs displayed an error in terminal but did not specify which doc caused it.

On Main:
Screen Shot 2021-07-01 at 6 17 42 PM
This PR:
Screen Shot 2021-07-01 at 6 16 59 PM

🧬 QA & Testing

For Docs Command:

  • Check that all valid docs in a folder update in the project
  • Check that the output to the console is easy to understand when an invalid doc is in folder

@erunion erunion changed the title fix: change swagger command to always update all valid docs fix: change docs command to always update all valid docs Jul 7, 2021
__tests__/cmds/docs.test.js Show resolved Hide resolved
@rahulhegdee rahulhegdee requested a review from erunion July 7, 2021 20:46
@erunion erunion added the enhancement New feature or request label Jul 8, 2021
@erunion erunion merged commit 792a2b2 into main Jul 9, 2021
@erunion erunion deleted the validate-markdown-files-before-uploading-rm-1392 branch July 9, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants