Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate files before uploading in swagger command #332

Merged
merged 3 commits into from
Jun 30, 2021
Merged

fix: validate files before uploading in swagger command #332

merged 3 commits into from
Jun 30, 2021

Conversation

rahulhegdee
Copy link
Contributor

🧰 Changes

  • Added validation for files prior to creating/updating them in the project
  • Added test to check validation

🧬 QA & Testing

  • Make sure that invalid files throw an error
  • Make sure that valid files still upload successfully

@rahulhegdee rahulhegdee requested review from erunion and gratcliff June 26, 2021 01:21
@erunion erunion added the enhancement New feature or request label Jun 29, 2021
erunion
erunion approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@erunion erunion merged commit 670f9c4 into main Jun 30, 2021
@erunion erunion deleted the rdme-doesnt-validate-swagger-files-rm-1190 branch June 30, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

@gratcliff gratcliff Awaiting requested review from gratcliff

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulhegdee @erunion