feat: overhauling error handling to support the new api error responses #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Jul 15, 2020
| @@ -49,6 +50,9 @@ exports.run = function (opts) { | |||
| } | |||
|
|
|||
| const files = fs.readdirSync(folder).filter(file => file.endsWith('.md') || file.endsWith('.markdown')); | |||
| if (files.length === 0) { | |||
| return Promise.reject(new Error(`We were unable to locate Markdown files in ${folder}.`)); | |||
There was a problem hiding this comment.
Adding this error message because if a user tries to use rdme docs with a directory that has subdirectories containing Markdown, we currently can't handle those Markdown files as rdme docs can't handle category creation and management right now.
domharrington
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This overhauls every command to support the new way we're handling errors within the API and allowing us to surface Metrics log IDs in the console for API failures