fix: executable issue for linux users #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
changed the title
kellyjosephprice
approved these changes
Dec 9, 2024
|
@kellyjosephprice i'm flying blind here so i could not tell you lol |
kanadgupta
pushed a commit
that referenced
this pull request
Dec 9, 2024
## [9.0.1-next.2](v9.0.1-next.1...v9.0.1-next.2) (2024-12-09) ### Bug Fixes * executable issue for linux users ([#1115](#1115)) ([4319fb5](4319fb5)) [skip ci]
|
🎉 This PR is included in version 9.0.1-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
For what it's worth, the |
|
@joshbeard appreciate you flagging this — mind taking a look at #1117 and seeing if that takes care of this issue? If not, might be good to add additional docs to our setup instructions. |
kanadgupta
added a commit
that referenced
this pull request
Dec 10, 2024
## 🧰 Changes The whole reasoning behind #1115 is because we pass flags in order to avoid emitting this `ExperimentalWarning` for Node v20 users:  Per [this comment](#1115 (comment)), adding `-S` might be problematic for certain container setups. As a result, I just overhauled how we import JSON in our production code so we don't need that Node CLI flag at all. At some point I'd love if we got to a point where we can fully rely on the oclif config for `package.json` attributes but today is not that day! ## 🧬 QA & Testing When you check out this branch and run the following commands... - Do they run properly without hanging? (hopefully yes) - Do you see Node `ExperimentalWarning` outputs (like the above screenshot) at any point? (hopefully no) ```sh npm ci && npm run build bin/run.js ```
kanadgupta
pushed a commit
that referenced
this pull request
Dec 10, 2024
## [9.0.2-next.1](v9.0.1...v9.0.2-next.1) (2024-12-10) ### Bug Fixes * remove import attributes ([#1117](#1117)) ([e662654](e662654)), closes [#1115](#1115) [/github.com//pull/1115#issuecomment-2532123627](https://github.com//github.com/readmeio/rdme/pull/1115/issues/issuecomment-2532123627) [skip ci]
kanadgupta
pushed a commit
that referenced
this pull request
Dec 11, 2024
## [9.0.2](v9.0.1...v9.0.2) (2024-12-11) ### Bug Fixes * **autocomplete:** bad alias ([#1118](#1118)) ([5b8d928](5b8d928)) * remove import attributes ([#1117](#1117)) ([e662654](e662654)), closes [#1115](#1115) [/github.com//pull/1115#issuecomment-2532123627](https://github.com//github.com/readmeio/rdme/pull/1115/issues/issuecomment-2532123627) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Linux requires the
-Sflag when passing options tonodecommand-line in executable files. This was fun to troubleshoot 🥴🧬 QA & Testing
Can Linux users run the CLI again? 😮💨