refactor(oclif): renaming src/cmds to src/commands
#1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think this is causing clashes with oclif — plus we may not need it anymore?
- recreate base command auth + flags in oclif
this is probably where should do some error handling too but not sure how yet
this was causing errors in tests, will have to tackle this a different way
hopefully i can get oclif/test#652 merged 🤞🏽
to get lint to play nicely
erunion
changed the title
src/cmds to src/commandssrc/cmds to src/commands
kanadgupta
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
imma wait until #1068 is merged into next before merging this in because the diff is already crazy
|
closing in favor of #1070 |
kanadgupta
added a commit
that referenced
this pull request
Nov 19, 2024
## 🧰 Changes recreating @erunion's work in #1069: > This is a super minor addendum to the oclif work going on in #1068 but I've renamed our `src/cmds` directory to `src/commands` as when you run `oclif generate command <command name>` that's the directory it wants to place a new command into. > > We could _probably_ configure `src/cmds` somehow to be the place it looks but I don't see anything in their [config docs](https://oclif.io/docs/config) about it. Co-authored-by: Jon Ursenbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This is a super minor addendum to the oclif work going on in #1068 but I've renamed our
src/cmdsdirectory tosrc/commandsas when you runoclif generate command <command name>that's the directory it wants to place a new command into.We could probably configure
src/cmdssomehow to be the place it looks but I don't see anything in their config docs about it.