Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump #1041

Merged
merged 8 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,24 @@
{
"files": ["bin/*.js"],
"rules": {
"@typescript-eslint/no-var-requires": "off"
}
}
"@typescript-eslint/no-var-requires": "off",
},
},
],
"env": {
"es2021": true,
"node": true
"node": true,
},
"parserOptions": {
"sourceType": "module"
"sourceType": "module",
},
"rules": {
"@typescript-eslint/ban-types": [
"error",
{
"types": {
// We specify `{}` in `CommandOptions` generics when those commands don't have their own
// options and it's cleaner for us to do that than `Record<string, unknown>`.
"{}": false
}
}
],
// We specify `{}` in `CommandOptions` generics when those commands don't have their own
// options and it's cleaner for us to do that than `Record<string, unknown>`.
"@typescript-eslint/no-empty-object-type": "off",

// We already have top-level error handling across the codebase, so this rule is not helpful for us.
"try-catch-failsafe/json-parse": "off",

/**
* Because our command classes have a `run` method that might not always call `this` we need to
Expand Down Expand Up @@ -57,13 +53,13 @@
"paths": [
{
"name": "ci-info",
"message": "The `ci-info` package is difficult to test because misleading results will appear when running tests in the GitHub Actions runner. Instead of importing this package directly, create a wrapper function in `lib/isCI.ts` and import that instead."
}
]
}
"message": "The `ci-info` package is difficult to test because misleading results will appear when running tests in the GitHub Actions runner. Instead of importing this package directly, create a wrapper function in `lib/isCI.ts` and import that instead.",
},
],
},
],

// This rule is only really applicable for OSS libraries and doesn't apply to rdme's case.
"readme/no-dual-exports": "off"
}
"readme/no-dual-exports": "off",
},
}
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ jobs:
# https://github.com/nvm-sh/nvm/issues/1998#issuecomment-594958684
- lts/-1
- lts/*
- 22.2 # temporarily pinning due to fetch mocking failures on node v22.3, see https://github.com/readmeio/rdme/pull/1019#issuecomment-2201147488
# - latest
- latest

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions bin/docker.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// @ts-check
/* eslint-disable no-console */
import { execFile as unpromisifiedExecFile } from 'node:child_process';
import util from 'node:util';
import { promisify } from 'node:util';

const execFile = util.promisify(unpromisifiedExecFile);
const execFile = promisify(unpromisifiedExecFile);

/**
* Retrieves and parses the docker image metadata
Expand Down
4 changes: 2 additions & 2 deletions bin/set-major-version-tag.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#! /usr/bin/env node
// @ts-check
import { execFile as unpromisifiedExecFile } from 'node:child_process';
import util from 'node:util';
import { promisify } from 'node:util';

import { parse } from 'semver';

import pkg from '../package.json' with { type: 'json' };

const execFile = util.promisify(unpromisifiedExecFile);
const execFile = promisify(unpromisifiedExecFile);

/**
* Runs command and logs all output
Expand Down
Loading