Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename swagger command to openapi and keep swagger as alias #333

Merged
merged 10 commits into from
Jul 6, 2021
Merged

feat: rename swagger command to openapi and keep swagger as alias #333

merged 10 commits into from
Jul 6, 2021

Conversation

rahulhegdee
Copy link
Contributor

@rahulhegdee rahulhegdee commented Jun 30, 2021 •
edited
Loading

🧰 Changes

  • renames swagger command to openapi
  • keeps swagger command as an alias to the openapi command

QA & Testing

  • check that both openapi and swagger commands work the same

@rahulhegdee rahulhegdee requested a review from erunion June 30, 2021 18:31
erunion
erunion requested changes Jun 30, 2021
View reviewed changes
src/cmds/swagger.js Outdated Show resolved Hide resolved
__tests__/cmds/openapi.test.js Outdated Show resolved Hide resolved
@rahulhegdee rahulhegdee requested a review from erunion June 30, 2021 21:58
Base automatically changed from rdme-doesnt-validate-swagger-files-rm-1190 to main June 30, 2021 22:11
erunion
erunion approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just merged #332 in so you've got a conflict now, but once that's resolved I'll pull this in!

@erunion erunion merged commit 04e7f93 into main Jul 6, 2021
@erunion erunion deleted the rename-the-swagger-command-to-openapi-rm-1238 branch July 6, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulhegdee @erunion