feat: dropping support for node 10, expanding coverage to node 14/16 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
force-pushed
the
feat/drop-node10
branch
from
0adf995 to
82e35ac
Compare
This was referenced Jun 19, 2021
kanadgupta
reviewed
Jun 21, 2021
rahulhegdee
approved these changes
Jun 21, 2021
ollyfg
pushed a commit
to ollyfg/rdme
that referenced
this pull request
Jun 22, 2021
…eadmeio#325) * feat: dropping support for node 10 * test: fixing a broken test on node 14 * ci: updating the ci workflow to use node 12+ * ci: upgrading the codeql workflow to the latest way it configs * chore(deps-dev): upgrading jest to v27 * chore(deps-dev): upgrading code styling dev deps * chore(deps-dev): upgrading nock to the latest version * chore: removing a swagger file that shouldnt be in the root dir? * ci: updating codeql to run on `main` not `master` * fix: removing the `main` declaration because it doesnt exist
RM-1218 Drop support for Node 10
Drop support for Node 10, ensure that tests run across all LTE releases of Node: 12, 14, 16. |
RM-1219 Upgrade the lockfile and CI to use NPM 7
We use NPM 7 mostly everywhere now, so we should update the dev workflow of
This'll require us to have to bump to a breaking change with Semver, but I can handle that when we're ready to publish a new release. |
rahulhegdee
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Add --recursive option to doc sync command This option causes a simple recursive search of the supplied folder. * Whoops! Typo * docs: adding a pull request template * feat: dropping support for node 10, expanding coverage to node 14/16 (#325) * feat: dropping support for node 10 * test: fixing a broken test on node 14 * ci: updating the ci workflow to use node 12+ * ci: upgrading the codeql workflow to the latest way it configs * chore(deps-dev): upgrading jest to v27 * chore(deps-dev): upgrading code styling dev deps * chore(deps-dev): upgrading nock to the latest version * chore: removing a swagger file that shouldnt be in the root dir? * ci: updating codeql to run on `main` not `master` * fix: removing the `main` declaration because it doesnt exist * chore: directory spring cleaning (#327) * feat: dropping support for node 10 * test: fixing a broken test on node 14 * ci: updating the ci workflow to use node 12+ * ci: upgrading the codeql workflow to the latest way it configs * chore(deps-dev): upgrading jest to v27 * chore(deps-dev): upgrading code styling dev deps * chore(deps-dev): upgrading nock to the latest version * chore: removing a swagger file that shouldnt be in the root dir? * ci: updating codeql to run on `main` not `master` * chore: updating the license to be 2021 * chore: renaming the test directory to `__tests__` * chore: various dotfile cleanup * chore: moving the codebase into a `src/` directory structure * Bugfix: Get rid of re-declaration Co-authored-by: Jon Ursenbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RM-1218
Fixes RM-1219
🧰 Changes
🚨 This'll be a breaking change and will require a bump to
rdme@4!engines, and CI testing, coverage to Node 14 and Node 16.eslint,prettier,nock,@readme/eslint-config,jest🧬 QA & Testing