feat: dropping support for node 12 (#440)

* feat: dropping support for node 12

* feat: adding optional chaining in a few other spots

.eslintrc

@@ -1,6 +1,9 @@
 {
   "extends": ["@readme/eslint-config"],
   "root": true,
+  "parserOptions": {
+    "ecmaVersion": 2020
+  },
   "rules": {
     /**
      * Because our command classes have a `run` method that might not always call `this` we need to

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [14.x, 16.x]
 
     steps:
       - uses: actions/[email protected]

bin/rdme

@@ -20,7 +20,7 @@ require('../src')(process.argv.slice(2))
       '[email protected]'
     )}.`;
 
-    if (err && 'message' in err) {
+    if (err?.message) {
       message = err.message;
     }
 

package.json

@@ -5,7 +5,7 @@
   "license": "MIT",
   "author": "ReadMe <[email protected]> (https://readme.com)",
   "engines": {
-    "node": "^12 || ^14 || ^16"
+    "node": "^14 || ^16"
   },
   "bin": {
     "rdme": "bin/rdme"
@@ -23,7 +23,8 @@
     "oas",
     "apidoc",
     "microservice",
-    "documentation"
+    "documentation",
+    "readme"
   ],
   "repository": {
     "type": "git",

src/lib/apiError.js

@@ -4,7 +4,7 @@ module.exports = class extends Error {
 
     // Special handling to for fetch `res` arguments where `res.error` will contain our API error response.
     if (typeof res === 'object') {
-      if ('error' in res && typeof res.error === 'object') {
+      if (typeof res?.error === 'object') {
         err = res.error;
       } else {
         err = res;
@@ -20,7 +20,7 @@ module.exports = class extends Error {
 
       // If we returned help info in the API, show it otherwise don't render out multiple empty lines as we sometimes
       // throw `Error('non-api custom error message')` instances and catch them with this class.
-      if ('help' in err) {
+      if (err?.help) {
         this.message = [err.message, '', err.help].join('\n');
       } else {
         this.message = err.message;

src/lib/prompts.js

@@ -148,7 +148,7 @@ exports.createVersionPrompt = (versionList, opts, isUpdate) => [
     name: 'is_stable',
     message: 'Would you like to make this version the main version for this project?',
     skip() {
-      return opts.main || (isUpdate && isUpdate.is_stable);
+      return opts.main || isUpdate?.is_stable;
     },
   },
   {