Skip to content

Commit

Permalink
chore(eslint): consistenly sorting on interface props (#820)
Browse files Browse the repository at this point in the history
Co-authored-by: Kanad Gupta <[email protected]>
  • Loading branch information
erunion and kanadgupta authored Jun 6, 2023
1 parent 2d301b9 commit 2ab05ba
Show file tree
Hide file tree
Showing 18 changed files with 279 additions and 49 deletions.
2 changes: 1 addition & 1 deletion __tests__/cmds/openapi/inspect.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('rdme openapi:inspect', () => {
).rejects.toStrictEqual(new Error('Unknown features: reamde. See `rdme help openapi:inspect` for help.'));
});

const cases: { spec: string; feature: string[]; shouldSoftError?: true }[] = [
const cases: { feature: string[]; shouldSoftError?: true; spec: string }[] = [
{
spec: '@readme/oas-examples/3.0/json/readme.json',
feature: ['polymorphism'],
Expand Down
2 changes: 1 addition & 1 deletion __tests__/lib/createGHA.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ describe('#createGHA', () => {

describe('command inputs', () => {
describe.each<{
cmd: keyof typeof commands;
CmdClass: typeof Command;
cmd: keyof typeof commands;
/** used to differentiate describe blocks */
label: string;
opts: CommandOptions<Record<string, string>>;
Expand Down
245 changes: 238 additions & 7 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"@commitlint/cli": "^17.4.2",
"@commitlint/config-conventional": "^17.4.2",
"@readme/better-ajv-errors": "^1.5.0",
"@readme/eslint-config": "^10.3.1",
"@readme/eslint-config": "^10.6.0",
"@readme/oas-examples": "^5.10.0",
"@types/command-line-args": "^5.2.0",
"@types/command-line-usage": "^5.0.2",
Expand Down
2 changes: 1 addition & 1 deletion src/cmds/categories/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ interface Category {

export interface Options {
categoryType?: 'guide' | 'reference';
title?: string;
preventDuplicates?: boolean;
title?: string;
}

export default class CategoriesCreateCommand extends Command {
Expand Down
2 changes: 1 addition & 1 deletion src/cmds/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import loginFlow from '../lib/loginFlow';

export interface Options {
email?: string;
password?: string;
otp?: string;
password?: string;
project?: string;
}

Expand Down
2 changes: 1 addition & 1 deletion src/cmds/open.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import getCurrentConfig from '../lib/getCurrentConfig';
import { getProjectVersion } from '../lib/versionSelect';

export interface Options {
mockOpen?: (url: string) => Promise<void>;
dash?: boolean;
mockOpen?: (url: string) => Promise<void>;
}

export default class OpenCommand extends Command {
Expand Down
2 changes: 1 addition & 1 deletion src/cmds/openapi/convert.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import promptTerminal from '../../lib/promptWrapper';
import { validateFilePath } from '../../lib/validatePromptInput';

export interface Options {
spec?: string;
out?: string;
spec?: string;
workingDirectory?: string;
}

Expand Down
Loading

0 comments on commit 2ab05ba

Please sign in to comment.