Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create a response description if one is missing #3

Merged
merged 1 commit into from
May 1, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented May 1, 2023

🚥 Fixes CX-268

🧰 Changes

If a Postman response does not have a description we'll now create one that matches the message of the corresponding HTTP Status Code. For example if the code is 404 then the description will be "Not Found".

@erunion erunion added the bug Something isn't working label May 1, 2023
@erunion erunion requested review from kanadgupta and Dashron May 1, 2023 17:42
@@ -0,0 +1 @@
declare module '@readme/http-status-codes';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a very easy library to export types for lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I might rewrite it in TS in a bit.

@erunion erunion merged commit b13f7e5 into main May 1, 2023
@erunion erunion deleted the fix/missing-response-descriptions branch May 1, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants