Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prevent tests from being run in subpackages #910

Merged
merged 3 commits into from
Oct 17, 2024
Merged

chore: prevent tests from being run in subpackages #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe27619
chore: only install vitest at root, prevent tests from being run in s…
kanadgupta Oct 17, 2024
20c4607
chore: bring back vitest installation
kanadgupta Oct 17, 2024
6cf4e08
test: type fix
kanadgupta Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions packages/oas-normalize/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"lint:types": "tsc --noEmit",
"prebuild": "rm -rf dist/",
"prepack": "npm run build",
"test": "vitest run --coverage"
"test": "echo 'Please run tests from the root!' && exit 1"
},
"license": "MIT",
"dependencies": {
Expand All @@ -73,12 +73,11 @@
"@readme/oas-examples": "^5.12.0",
"@types/js-yaml": "^4.0.9",
"@types/swagger2openapi": "^7.0.4",
"@vitest/coverage-v8": "^1.4.0",
"eslint": "^8.57.0",
"nock": "^14.0.0-beta.12",
"tsup": "^8.0.2",
"typescript": "^5.1.6",
"vitest": "^1.4.0"
"vitest": "^1.6.0"
},
"prettier": "@readme/eslint-config/prettier"
}
5 changes: 2 additions & 3 deletions packages/oas-to-har/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"lint:types": "tsc --noEmit",
"prebuild": "rm -rf dist/",
"prepack": "npm run build",
"test": "vitest run --coverage"
"test": "echo 'Please run tests from the root!' && exit 1"
},
"dependencies": {
"@readme/data-urls": "^3.0.0",
Expand All @@ -58,13 +58,12 @@
"@readme/oas-examples": "^5.12.0",
"@types/har-format": "^1.2.15",
"@types/qs": "^6.9.14",
"@vitest/coverage-v8": "^1.4.0",
"eslint": "^8.57.0",
"jest-expect-har": "^7.1.0",
"tsup": "^8.0.2",
"type-fest": "^4.18.3",
"typescript": "^5.2.2",
"vitest": "^1.4.0"
"vitest": "^1.6.0"
},
"prettier": "@readme/eslint-config/prettier"
}
3 changes: 2 additions & 1 deletion packages/oas-to-har/test/index.test.ts
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol type fix i noticed — we don't type check tests so it's not really a concern

Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Operation } from 'oas/operation';
import type { OASDocument } from 'oas/types';

import petstore from '@readme/oas-examples/3.0/json/petstore.json';
import toBeAValidHAR from 'jest-expect-har';
Expand Down Expand Up @@ -133,7 +134,7 @@ describe('oas-to-har', () => {
let operation;

beforeEach(function () {
variablesOas = new Oas(serverVariables);
variablesOas = new Oas(serverVariables as OASDocument);
operation = variablesOas.operation('/', 'post');
});

Expand Down
5 changes: 2 additions & 3 deletions packages/oas-to-snippet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"lint:types": "tsc --noEmit",
"prebuild": "rm -rf dist/",
"prepack": "npm run build",
"test": "vitest run --coverage"
"test": "echo 'Please run tests from the root!' && exit 1"
},
"dependencies": {
"@readme/httpsnippet": "^10.1.0",
Expand All @@ -57,14 +57,13 @@
"@readme/oas-examples": "^5.12.0",
"@types/har-format": "^1.2.14",
"@types/node": "^20.8.7",
"@vitest/coverage-v8": "^1.4.0",
"har-examples": "^3.1.1",
"httpsnippet-client-api": "^7.0.0-beta.4",
"oas": "file:../oas",
"tsup": "^8.0.2",
"type-fest": "^4.18.3",
"typescript": "^5.2.2",
"vitest": "^1.4.0"
"vitest": "^1.6.0"
},
"prettier": "@readme/eslint-config/prettier"
}
5 changes: 2 additions & 3 deletions packages/oas/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"lint:types": "tsc --noEmit",
"prebuild": "rm -rf dist/",
"prepack": "npm run build",
"test": "vitest run --coverage",
"test": "echo 'Please run tests from the root!' && exit 1",
"watch": "tsc --watch"
},
"dependencies": {
Expand All @@ -105,10 +105,9 @@
"@types/json-schema-merge-allof": "^0.6.5",
"@types/memoizee": "^0.4.11",
"@types/node": "^20.12.13",
"@vitest/coverage-v8": "^1.4.0",
"tsup": "^8.0.2",
"typescript": "^5.4.4",
"vitest": "^1.4.0"
"vitest": "^1.6.0"
},
"prettier": "@readme/eslint-config/prettier"
}