feat: make proxy address customizable #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting proxyUrl into a string would be possibly a breaking change, so instead I added a proxyAddress option which is a URL to use instead of try.readme.io The reason to make this change is so that I can test a beta version of try.readme.io safely in staging Bumped oas-to-har version to 23.3.0
kanadgupta
requested changes
Oct 17, 2024
kanadgupta
approved these changes
Oct 17, 2024
|
@kanadgupta do you want to bump the version or shall I? |
|
@llimllib i got it! i'm going to bump some dependencies also quick |
|
OK, I'd like to get it into the monorepo asap so tag me on a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Convert proxyUrl from a boolean to a string, so now it represents the URL of the proxy server instead of an option about whether to use a proxy server or not.
This is a breaking change and
oas-to-harshould get a version major bump when it's releasedThe reason to make this change is so that I can test a beta version of try.readme.io safely in staging
🧬 QA & Testing
I added a test, but this should be a pretty minimal change