feat(operation/getSecurityWithTypes): expose required scopes #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
commented
Aug 30, 2024
Comment on lines
-255
to
+256
| const exists = prev[security.type].findIndex(sec => sec._key === security.security._key); | ||
| if (exists < 0) { | ||
| const exists = prev[security.type].some(sec => sec._key === security.security._key); | ||
| if (!exists) { |
There was a problem hiding this comment.
this just moves us from Array.findIndex to Array.some for readability purposes
erunion
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
In our
operation.getSecurityWithTypes()method, this adds/documents a new property called_requirementsthat contains the required scopes for the operation + security scheme1.I also exported our
SecurityTypetype and added a JSDoc for it.🧬 QA & Testing
Should be a minor additive change. Do tests/snapshots pass?
Footnotes
read more about the security requirement object here ↩