fix(oas-extensions): moving oas from being a peer to a hard dep
#819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Oct 9, 2023
| @@ -39,7 +39,7 @@ | |||
| "prepack": "npm run build", | |||
| "test": "vitest run --coverage" | |||
| }, | |||
| "peerDependencies": { | |||
There was a problem hiding this comment.
This was originally a peer dep in https://github.com/readmeio/oas-extensions to save me the hassle of bumping it whenever I published a major release of oas but because they're all in the same repository now it makes sense to just have this listed as a regular dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Something I didn't know is that with Lerna if you use the
file:../<dirname>syntax for loading dependencies in a monorepo, but do that for a peer dependency, Lerna and NPM won't change thatfile:reference when publishing a release. This was causing issues withinoas-extensionswhere becauseoaswas listed as a peer dependency when I loaded in the latest release ofoas-extensionsit was trying to loadoasfrom the samefile:path in another repository of mine.Yikes!