refactor: random config file cleanup #817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Doing a little mess-around in this repo and refactored a few config files (some are a bit new and opinionated so feel free to push back on any of this)
.npmignore
files — these are no longer needed since we use thefiles
option (you can confirm this by runningnpm pack
and looking at the file list in any of the subpackages)prelint
step — it feels a bit counterintuitive that we need to build thedist
before we lint, so I figured this made sense..prettierignore
file — as of Prettier 3.0, files in the.gitignore
are ignored by default: https://prettier.io/blog/2023/07/05/3.0.0.html#cli.eslintignore
files in favor of the--ignore-path
CLI option — this is somewhat opinionated but I generally like being able to consolidate config file options when possible🧬 QA & Testing
To confirm the
npmignore
changes, you can confirm this by runningnpm pack
and looking at the file list in any of the subpackages. And if the linting step passes, the Prettier/ESLint config file changes should be safe.