Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: random config file cleanup #817

Merged
merged 4 commits into from
Oct 9, 2023
Merged

refactor: random config file cleanup #817

merged 4 commits into from
Oct 9, 2023

Conversation

kanadgupta
Copy link
Member

🧰 Changes

Doing a little mess-around in this repo and refactored a few config files (some are a bit new and opinionated so feel free to push back on any of this)

  • 5b70e53 Removed the .npmignore files — these are no longer needed since we use the files option (you can confirm this by running npm pack and looking at the file list in any of the subpackages)
  • f4d0b92 added a prelint step — it feels a bit counterintuitive that we need to build the dist before we lint, so I figured this made sense.
  • 91cacfd cleaned up the .prettierignore file — as of Prettier 3.0, files in the .gitignore are ignored by default: https://prettier.io/blog/2023/07/05/3.0.0.html#cli
  • afc5fd8 removed the .eslintignore files in favor of the --ignore-path CLI option — this is somewhat opinionated but I generally like being able to consolidate config file options when possible

🧬 QA & Testing

To confirm the npmignore changes, you can confirm this by running npm pack and looking at the file list in any of the subpackages. And if the linting step passes, the Prettier/ESLint config file changes should be safe.

@kanadgupta kanadgupta added the refactor Issues about tackling technical debt label Oct 9, 2023
@kanadgupta kanadgupta marked this pull request as ready for review October 9, 2023 16:22
@kanadgupta kanadgupta requested a review from erunion October 9, 2023 16:22
@erunion erunion merged commit ffb8ed2 into main Oct 9, 2023
@erunion erunion deleted the minor-cleanup branch October 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants