Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reducer): retain root-defined security definitions #791

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(reducer): retain root-defined security definitions #791

merged 1 commit into from
Aug 18, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 18, 2023

🚥 Resolves readmeio/rdme#860

🧰 Changes

If you use the reducer with an API definition that has a root-level security configuration we wouldn't retain the securityScheme components for those resulting in an invalid OpenAPI definition.

@erunion erunion added the bug Something isn't working label Aug 18, 2023
@erunion erunion requested a review from kanadgupta August 18, 2023 22:12
kanadgupta
kanadgupta approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑 you dropped this etc. etc.

@erunion erunion merged commit 3f0967f into main Aug 18, 2023
@erunion erunion deleted the fix/reduce-root-security-schemes branch August 18, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

securityScheme not included in reduced API definition
2 participants
@erunion @kanadgupta