Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removing getSchema, deprecating findSchemaDefinition #600

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 5, 2022

🧰 Changes

  • Removes the getSchema library that I deprecated a few releases back.
  • Marks findSchemaDefinition as deprecated. It's currently being used in how we fetch content types with Operation.getContentType() but since this library assumes everywhere that you've dereferenced your spec this code shouldn't get run on $ref pointers.
    • In a future release when I fully remove findSchemaDefinition I'll also refactor that getContentType() code.

@erunion erunion added the refactor Issues about tackling technical debt label Feb 15, 2022
@erunion erunion requested review from julshotal and gratcliff March 3, 2022 18:57
@erunion erunion merged commit 161611f into main Mar 8, 2022
@erunion erunion deleted the fix/remove-getschema branch March 8, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants