fix: exclude readonly params from deprecatedProps #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Dec 14, 2021
erunion
deleted the
fix/deprecated-readonly-true-will-hide-the-rm-2999
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We don't render readOnly params in the areas deprecatedProps are used for the accordion, so there's not point in adding them in and it can cause weird empty accordions if the only deprecated params are also readOnly.
This shouldn't affect responses where we do render readOnly params as we don't separate out deprecated params there
🧬 QA & Testing
see added test
if you sub the customer spec file where this was an issue for the deprecated spec in those tests, the tests will fail due to the deprecatedProps schema being null, which means this is working since their only deprecated prop is also readOnly