Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addition of an init and methods for pulling spec extensions #537

Merged
merged 5 commits into from
Nov 6, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Nov 5, 2021

🧰 Changes

  • Creates a static Oas.init() method that will do type transformation on raw JSON objects before it's sent into the Oas constructor. This helps so that we don't need to export RMOAS.OASDocument and you can do new Oas(petstore) out of the box.
  • Adds hasExtension() and getExtension() methods to both Oas and Operation for spec extensions lookups. We can use this in @readme/oas-extensions to clean up some work there.

🧬 QA & Testing

See tests.

@erunion erunion added enhancement New feature or request refactor Issues about tackling technical debt labels Nov 5, 2021
@erunion erunion changed the title feat: addition of an init and getExtension() methods feat: addition of an init and methods for pulling spec extensions Nov 5, 2021
@erunion erunion requested a review from julshotal November 5, 2021 21:50
Copy link
Member

@domharrington domharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fully understand why it's necessary but code LGTM!

@erunion erunion merged commit 84281da into main Nov 6, 2021
@erunion erunion deleted the feat/init-method branch November 6, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants