Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate items from enums #491

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 27, 2021

🧰 Changes

This updates our JSON Schema generation and handling of enum properties to filter out any duplicate items that may be present within it. Duplicate items in an enum will cause AJV to throw errors:

Screen Shot 2021-08-27 at 2 29 53 PM

🧬 QA & Testing

See tests.

@erunion erunion added the bug Something isn't working label Aug 27, 2021
@erunion erunion force-pushed the fix/filter-out-dupe-enum-values branch from e1f76e5 to f70f1cb Compare August 27, 2021 21:34
@erunion erunion merged commit 2a2fd81 into main Aug 27, 2021
@erunion erunion deleted the fix/filter-out-dupe-enum-values branch August 27, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant