Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quirk with request/response examples where readonly/writeonly was ignored in allOf #482

Merged
merged 2 commits into from
Aug 20, 2021
Merged

fix: quirk with request/response examples where readonly/writeonly was ignored in allOf #482

merged 2 commits into from
Aug 20, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 20, 2021

🧰 Changes

Fixes a quirk with readOnly and writeOnly where if they were within a schema that was in an allOf we wouldn't include them in generated examples.

Fixes RM-1765

🧬 QA & Testing

See tests.

@erunion erunion added the bug Something isn't working label Aug 20, 2021
@erunion erunion requested review from Dashron and julshotal August 20, 2021 20:40
Dashron
Dashron approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests make sense, code looks fine. I'll test more thoroughly in the next pr on site.

@erunion erunion merged commit 1968246 into main Aug 20, 2021
@erunion erunion deleted the fix/writeonly-readonly-allof-quirks branch August 20, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dashron Dashron Dashron approved these changes

@julshotal julshotal Awaiting requested review from julshotal

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @Dashron