Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: including refs when discriminator mappings are present #480

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 12, 2021

🧰 Changes

This fixes a problem introduced in #479 where discriminator mapping component schemas weren't being included in generated JSON Schema because those aren't defined with a traditional $ref property.

🧬 QA & Testing

See tests.

@erunion erunion added the bug Something isn't working label Aug 12, 2021
@erunion erunion merged commit b9e93fa into main Aug 12, 2021
@erunion erunion deleted the fix/discriminator-mapping-missing-refs branch August 12, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant