fix: quirk where a path with a query string would break matching #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domharrington
approved these changes
Jun 28, 2021
| @@ -74,7 +74,13 @@ function normalizePath(path) { | |||
| // variable starts. | |||
| // | |||
| // For example if the URL is `/post/:param1::param2` we'll be escaping it to `/post/:param1\::param2`. | |||
| return path.replace(/{(.*?)}/g, ':$1').replace(/::/, '\\::'); | |||
| return ( | |||
There was a problem hiding this comment.
Wonder if we could utilize the URL constructor here?
> new URL('/rating_stats?listing_ids[]=1234567', 'https://example.com').pathname
'/rating_stats'
> new URL('/people/GWID:3', 'https://example.com').pathname
'/people/GWID:3'
There was a problem hiding this comment.
That's not a bad idea. Will look into that after I get this fix up to the preview site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This fixes a quirk in our
findOperation()method where if a path in the API definition had a query param (like?param=123it would completely kill the method because the?was being interpreted as a regex modifier for path-to-regexp. To resolve this, I've loosened up matching on these kinds of paths so it'll look on/pathinstead of/path?param=123.Fixes RM-1396
🧬 QA & Testing
I've added test cases for the initial regression as well as some other potential variants of this quirk.