Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

fix: split out type exports #241

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: split out type exports #241

merged 1 commit into from
Sep 21, 2023

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Sep 20, 2023

🧰 Changes

I believe this is a quirk with tsup where default export functions don't play nicely with CJS repositories. This PR slightly shifts things around so all types are stored in a separate file, which is now surfaced in our exports.

Before:

CleanShot 2023-09-20 at 18 20 21@2x

After:

CleanShot 2023-09-20 at 18 21 29@2x

🧬 QA & Testing

If tests pass and ATTW seems to like these changes, we should be good to go!

@kanadgupta kanadgupta marked this pull request as ready for review September 21, 2023 16:19
@kanadgupta kanadgupta added bug Something isn't working refactor Issues about tackling technical debt labels Sep 21, 2023
@kanadgupta kanadgupta merged commit c5f3846 into main Sep 21, 2023
@kanadgupta kanadgupta deleted the split-out-type-exports branch September 21, 2023 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant