Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

refactor(test): moving tests over to vitest #223

Merged
merged 2 commits into from
Aug 14, 2023
Merged

refactor(test): moving tests over to vitest #223

merged 2 commits into from
Aug 14, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 13, 2023

🧰 Changes

I am obsessed with Vitest. Look at these gains! 💪

Before

Test Suites: 7 passed, 7 total
Tests:       2 skipped, 2 todo, 271 passed, 275 total
Snapshots:   0 total
Time:        2.34 s
Ran all test suites.
npx jest  18.00s user 1.38s system 637% cpu 3.040 total

After

 Test Files  7 passed (7)
      Tests  271 passed | 2 skipped | 2 todo (275)
   Start at  20:27:36
   Duration  593ms (transform 838ms, setup 0ms, collect 1.91s, tests 348ms, environment 1ms, prepare 398ms)

npx vitest run  2.99s user 0.65s system 363% cpu 0.998 total

@erunion erunion added enhancement New feature or request refactor Issues about tackling technical debt labels Aug 13, 2023
@erunion erunion requested a review from kanadgupta August 13, 2023 03:31
@@ -47,4 +47,4 @@ jobs:

- run: npm ci
- run: npm run build
- run: npx jest
- run: npm run test --ignore-scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reasoning behind the --ignore-scripts flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im running linting in a separate job

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants