fix: unified snippet QA #902
Conversation
i had to downgrade to npm@7 for this... absolutely cursed
not sure why VS code didn't flag these the first time 🤔 also i know this is nuts but open to alternatives lol
Co-Authored-By: Jon Ursenbach <[email protected]>
Co-Authored-By: Jon Ursenbach <[email protected]>
this is the shit i live for
Co-Authored-By: Bill Mill <[email protected]>
Co-Authored-By: Bill Mill <[email protected]>
Co-Authored-By: Bill Mill <[email protected]>
Co-Authored-By: Aaron Hedges <[email protected]>
have i mentioned i hate this? because i hate this
| @@ -8,10 +8,12 @@ | |||
| "lib": ["es2019"], | |||
| "outDir": "./dist", | |||
| "resolveJsonModule": true, | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
unfortunately this flag is required since the api core doesn't play nicely with TS strict mode (or maybe it's because we support Node 14 in this repo? not sure). i started readmeio/api#696 which could maybe help?
| "strict": true | ||
| }, | ||
| "include": [ | ||
| "src/**/*", | ||
| "src/.api/**/*", |
There was a problem hiding this comment.
i was running into build issues with the nested .api/apis/developers/package.json stuff so what i did instead was install api, json-schema-to-ts, etc. in packages/node/package.json and moved the .api directory into the src/ folder so it gets properly included in the TS build
cc: @erunion
There was a problem hiding this comment.
wonder if it'd be fine if the codegen'd SDK was JS instead
There was a problem hiding this comment.
i tried both JS and TS exports and TS even more unhappy with the former
🧰 Changes
This PR is dedicated purely to basic cleanup in #879. Any actual changes to the end-user experience (function signature changes, etc.) will come in subsequent PRs. Here are a few callouts:
crypto-jsin favor of using Node's nativecryptoapiusage for a code-gen'd, fully typed SDK🧬 QA & Testing
Do tests pass and do the changes look good?