feat: creation of a new interface for combined target + client installation #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
In
@readme/oas-to-snippet
right now the way we're installinghttpsnippet-client-api
is the following:This works normally but because we'd love to have folks create their own client plugins and give us NPM packages we don't want to have to supply a target for these plugins when it's easier if the plugin can define that themselves.
The work I've done here is to create a new
addClientPlugin
hook for installing a one of these target + client combinations and then also a newClientPlugin
interface that combines the two so we can enforce that plugins are properly defined:With all this work we'll be able to now execute the folllowing to install
httpsnippet-client-api
(once it's been converted to this new system of course):