Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

♻️ be more selective about which docs to lazy render #224

Merged
merged 7 commits into from
Jun 26, 2019

Conversation

dok
Copy link
Contributor

@dok dok commented Jun 21, 2019

No description provided.

@dok dok marked this pull request as ready for review June 21, 2019 20:44
@dok dok requested a review from domharrington June 21, 2019 20:44
@domharrington
Copy link
Member

@erunion think this is good to go! @kanadgupta can you work together to build a release for this?

Copy link
Member

@domharrington domharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple more test cases, but this looks great and works well!

@@ -11320,30 +11317,20 @@
},
"dependencies": {
"ajv": {
"version": "6.10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dok Did you mean to downgrade ajv here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not intend to downgrade. The update to package-lock.json was a result of running npx lerna bootstrap.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K cool, just checking. Looks like 5.5.2 falls in line with what the react-jsonschema-form dependency is requesting anyways so 👍

@erunion erunion merged commit 5e58131 into master Jun 26, 2019
@erunion erunion deleted the update/lazy-load branch June 26, 2019 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants