Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance/newsletter #30

Merged
merged 19 commits into from
Jun 10, 2024
Merged

Instance/newsletter #30

merged 19 commits into from
Jun 10, 2024

Conversation

everyplace
Copy link
Collaborator

@everyplace everyplace commented Apr 11, 2024

This PR adds a set of examples for the newsletter api.

Note

The code in this PR has been updated to include the final API.

This PR is available for preview here.

In addition, this PR adds a few new capabilities:

  • Adds an ability to configure the language parameter in the html template
  • Adds a new capability to hide items from the navigation

@@ -111,17 +111,21 @@
<div class="developer-site-nav">

{{#each data.nav}}
<hr />
{{#unless this.options.suppressInNav}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This level of suppression suppresses the entire category from displaying.

<h3 class="developer-site-nav-header developer-site-nav-title" >{{this.section}}</h3>
<ul class="developer-site-nav-list">
{{#each this.links}}
{{#unless this.options.suppressInNav}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This level of suppression only suppresses this item within the category.

@everyplace everyplace requested a review from mhkawano June 6, 2024 16:11
mhkawano
mhkawano previously approved these changes Jun 6, 2024
Copy link

@mhkawano mhkawano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/content/newsletter-automatic.md Outdated Show resolved Hide resolved
app/views/layouts/demo-layout.html Show resolved Hide resolved
mhkawano
mhkawano previously approved these changes Jun 10, 2024

const availableInterventions = await subscriptions.getAvailableInterventions();

const prompt = availableInterventions.find(({intervention}) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: same issue

@everyplace everyplace merged commit a61563a into main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants