Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to build cew with espeak-ng #258

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

danielbair
Copy link
Contributor

Tested on windows and mac.

Set AENEAS_USE_ESPEAKNG=True to build cew with espeak-ng

StephenMcConnel and others added 4 commits May 11, 2020 11:23
Also fix spurious warning messages that occur for at least python 3.8.
…ebianPackage-20200402

Add package for python3-aeneas
Copy link
Contributor Author

@danielbair danielbair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debian changes are not mine...

@danielbair
Copy link
Contributor Author

danielbair commented Jul 15, 2020

espeak-ng installer for windows can be downloaded from their repository.

espeak-ng for mac is available from MacPorts and HomeBrew (from my homebrew-tap).

@readbeyond
Copy link
Owner

@danielbair is this PR still relevant / needed / desired ?

@danielbair
Copy link
Contributor Author

On linux the espeak-ng packages provide a full replacement for espeak. But on Windows and Mac the espeak-ng package doesn't provide full espeak replacement files. So this PR does help Mac and Windows use espeak-ng with cew. I am implementing this PR when building the AIO installer, but this would allow others to benefit from this for installing via other methods.

@dhouck
Copy link

dhouck commented Mar 3, 2023

On Arch linux it looks like espeak-ng now doesnʼt even fully replace espeak from the dev perspective, just the command-line tools (maybe thereʼs something in the AUR that does but I didnʼt see it), so I had to build without CEW even on linux.

Copy link

@abathur abathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to this changeset broadly, but I can at least note that the changes in b80b1ca helped me build aeneas with cew support via Nix.

(The espeak package in nixpkgs isn't buildable on macOS since it hasn't been patched to disable the async feature as homebrew does. I wasn't sure about the consequences of patching the feature out, so I decided to try the espeak-ng approach first...)

@@ -156,6 +221,7 @@ def prepare_cew_for_windows():
IS_LINUX = (os.name == "posix") and (os.uname()[0] == "Linux")
IS_OSX = (os.name == "posix") and (os.uname()[0] == "Darwin")
IS_WINDOWS = (os.name == "nt")
IS_64BITS = (sys.maxsize > 2**32)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to patch in an import sys to get this working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants