Should we release 0.72.4?

[kelset]

Released, please refer to #85

---

Current Release: 0.72.3

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

No more pick requests are being accepted unless exceptional.

Release crew is waiting on Metro changes and then will do testing

Commits Picked

• enterKeyHint types on TextInput
  • facebook/react-native@5062553
• Allow string transform style in TypeScript
  • facebook/react-native@2558c3d
• Support for Android 14
  • For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED: facebook/react-native@177d97d
• Merged fix[AppContainer]: mount react devtools overlay only when devtools are attached facebook/react-native#38785
• Merged Bump CLI to 11.3.6 facebook/react-native#38778
• Fix inverted flatlist android 13 facebook/react-native@6d206a3 & facebook/react-native@3dd816c
• Fabric Interop
  • facebook/react-native@995bb3e
  • facebook/react-native@ccc50dd
• Fix Android ScrollView not responding to Keyboard events when nested inside a KeyboardAvoidingView
  • facebook/react-native@c616148
• fix: Correctly assign the hermes-engine pod tag when installing pod
  • facebook/react-native@08688d3
• Remove option to paste rich text from Android EditText context menu
  • facebook/react-native@b1ceea4
• Released a new Hermes version with pick:
  • facebook/hermes@8fd20f2
• Update new_architecture.rb for React-ImageManager
  • facebook/react-native@1761aea dropped
• Restore checking shadow tree commit cancellation after commit hook
  • facebook/react-native@a30f393
• Pass hitSlop prop into TextInput Pressability config
  • facebook/react-native@d6ff5c6

Waiting on

• metro-side: @huntie is taking care of this
  • Merged in Metro facebook/metro@6922933
  • Merged in CLI Upgrade Metro dependencies to 0.76.8 (hotfix) (11.x) react-native-community/cli#2048
  • Committed as Bump cli and metro facebook/react-native#38898 by @lunaleaps

Will not pick

• Set size of Modal only once on Android facebook/react-native#35803

List of issues we're aware of

• TextView on production nuking app with OverlappingFileLockException facebook/react-native#37871
• 0.72 Regression in Direct Debugging on Android facebook/react-native#38204

Local commits to backport to main

1. facebook/react-native@8ce471e (from 72.1)
2. facebook/react-native@8f41f25 (TBD if this revert will be done in main branch too, depends on this discussion and the planning for 0.73 )

[efstathiosntonas]

Added this on the list

• fix: text cut off phenomenon on some Android devices like OPPO, Xiaomi and etc facebook/react-native#37271

Fixes this: facebook/react-native#15114

[kelset]

gotcha - yeah honestly I understand your POV in trying to shine a light on this; I wish I had a good explanation or a plan we could act on about it, but it's out of my hands 😓

Probably this is not the right place to have this conversation but until someone from Meta chimes in let's leave it open

[efstathiosntonas]

Added to the list:

• Fix copy / paste menu and simplify controlled text selection on Android facebook/react-native#37424

[cortinico]

Hey @efstathiosntonas - Nicola here from the React Native team.

We do try to review and merge as many PRs as we could, but sometimes things fall through the crack as PRs were old (opened before we had a review process in place) or just more complex and require time to review.

Thanks for sharing this list, but it's harder for us to merge them all at once. What would be the most crucial one (and why)? We can prioritise them and try to get them merged.

For the rest, these releases discussions should be kept for standard cherry-pick requests; so I'll go ahead and hide this as "off topic". But thanks for forcing the conversation to happen.

[efstathiosntonas]

@cortinico Hi, I really can't tell which one should be reviewed, imho they are all important since they do not have workaround fixes. I guess you should pick the ones that are the easiest to review 🤷‍♂️ . The comment is not marked as off-topic (yet?), just fyi. Thank you for all your hard work guys/gals.

[kelset]

Need a CLI bump: facebook/react-native#38270 (comment)

11.3.6

[szymonrybczak]

facebook/react-native#38778

[lunaleaps]

picked

[cortinico]

This is a fix for the Interop Layer to support react-native-maps and other libraries that are using direct events:

• Fabric Interop - Also normalize direct events facebook/react-native#38352

Not merged yet, but should be picked as soon as it's out.

[cortinico]

It was merged so should be good to be picked up

[lunaleaps]

picked

[fortmarek]

Please, create a new issue in the react-native repository instead, including with reproduction steps. This discussion is only meant for pick requests of commits already in main.

[efstathiosntonas]

@mwaleed-39 stop spamming this discussion, this is not stackoverflow, no one will help you. Follow these instructions: #83 (reply in thread)

[t0nyh0]

Can we consider this for apps implementing chat-style interfaces:

facebook/react-native@6d206a3

[Titozzz]

I think we'll wait for both to landed to cherry pick :)

[t0nyh0]

Looks like this has been merged. Can we cherry pick? :-)

[Titozzz]

added both to the list

[hannojg]

Specifically its these two PRs:

• [Native part] Add workaround for android API 33 ANR when inverting ScrollView facebook/react-native#38071
• Add workaround fix for #35350 facebook/react-native#38073

[lunaleaps]

picked

[cortinico]

There is another fix for Fabric Interop for Android that extends the set of libraries we support:

• Fabric Interop - Properly dispatch integer commands facebook/react-native#38527

To be picked once it's merged

[lunaleaps]

I'm getting a pick conflict on this. Asking @cortinico to help merge: https://github.com/facebook/react-native/pull/38823/files

[cortinico]

Here the resolution of the conflicts:

• [LOCAL] Fabric Interop - Properly dispatch integer commands (#38527) facebook/react-native#38835

[nvodoor]

Could we consider cherry-picking in facebook/react-native@177d97d? It is needed for Android 14 support.

[lunaleaps]

picked

[billnbell]

Can we consider facebook/react-native#38247 it added React-ImageManager

[lunaleaps]

Can you expand on why this is necessary for this patch? Is it fixing essential behavior?

[billnbell]

I am pretty sure React-ImageManager was missed and should be in the list of core modules. It is needed for several react-native-blog* and fast-image, etc. So for me it is critical and needed, plus should have been there from 0.72.0

[fortmarek]

After discussing it with the release crew, we decided to pick this one (already done). Thanks for raising this!

[lunaleaps]

We've had to drop this commit because it has conflicts with the release branch. It's been removed from 0.72 for now

[fabOnReact]

Could we consider Remove option to paste rich text from Android EditText context menu facebook/react-native@b1ceea4? Fixes an issue reported in several chat applications (Expensify and Zulip-Mobile). Thanks a lot.

[lunaleaps]

picked

[efstathiosntonas]

Please consider picking this, it solves an issue with KeyboardAvoidingView and ScrollView on Android:

• Fix Android ScrollView not responding to Keyboard events when nested inside a KeyboardAvoidingView facebook/react-native#38728

[lunaleaps]

picked

[hannojg]

Whoops, has already been raised here: #83 (comment)

[fortmarek]

Thanks, yes, we will try picking both of these!

[Titozzz]

facebook/react-native@5062553 adds missing types to a prop that has been added in 0.71

[lunaleaps]

picked

[cipolleschi]

facebook/react-native#38754 this is landed today, but it will solve an update problem with hermes, so it would be nice to have it in 0.72.4.

[lunaleaps]

picked

[NickGerleman]

Typings fix for string transform style: facebook/react-native@2558c3d

[lunaleaps]

picked

[emzet93]

Performance improvement for JSON.stringify: facebook/hermes@8fd20f2

It's related to facebook/hermes#1008 and brings JSON.stringify performance closer to JSC implementation

[lunaleaps]

Asking the release crew whether this should be part of the pick

[lunaleaps]

picked

[cipolleschi]

Please don't ask ETAs in this discussion. This is meant to be used only to coordinate the release.
The release crew will release a new version of the framework when it's ready.

[lunaleaps]

I think this has already been picked to 0.72 https://github.com/facebook/react-native/blob/0.72-stable/packages/react-native/scripts/cocoapods/__tests__/utils-test.rb#L438

[Kudo]

oh my bad. didn't notice that is included from 0.72.0. that's awesome. thanks!

[efstathiosntonas]

Can we pick this:

• Restore checking shadow tree commit cancellation after commit hook execution  facebook/react-native#38715

it will improve reanimated performance and fix some crashes from both sides: software-mansion/react-native-reanimated#4833

[lunaleaps]

picked

[lunaleaps]

We are not taking anymore pick requests. We need to test at this stage.

[efstathiosntonas]

can we pick this: 🙏

• Pass hitSlop into usePressability facebook/react-native#38857

@lunaleaps sorry for rising this now but it's a really important prop

[lunaleaps]

picked

[kelset]

release crew specific improvement to merge asap (after patch is ok) -> facebook/react-native#38888

doesn't need a new patch, but merge for consistency across all versions in support window + main